Add contact forms template image #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Add contact forms image to `TEMPORARY_TEMPLATE_IMAGES` in `TemporaryTemplateImages.ts`. > > - **Behavior**: > - Add `contactFormsImage` import from `@/assets/contact-forms.png` in `TemporaryTemplateImages.ts`. > - Add `wpid_356554024867713766: contactFormsImage` to `TEMPORARY_TEMPLATE_IMAGES` in `TemporaryTemplateImages.ts`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 50743c0f21d472be12517f94f81e5903e39b0b79. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 5fb163f in 11 seconds
More details
- Looked at
13lines of code in1files - Skipped
1files when reviewing. - Skipped posting
4drafted comments based on config settings.
1. skyvern-frontend/src/routes/discover/TemporaryTemplateImages.ts:2
- Draft comment:
Confirm import path and asset existence for contactFormsImage. - Reason this comment was not posted:
Confidence changes required:0%
None
2. skyvern-frontend/src/routes/discover/TemporaryTemplateImages.ts:7
- Draft comment:
Verify mapping key and usage for contactFormsImage in TEMPORARY_TEMPLATE_IMAGES. - Reason this comment was not posted:
Confidence changes required:0%
None
3. skyvern-frontend/src/routes/discover/TemporaryTemplateImages.ts:2
- Draft comment:
Verify '@assets/contact-forms.png' exists and follows naming conventions. - Reason this comment was not posted:
Confidence changes required:33%
None
4. skyvern-frontend/src/routes/discover/TemporaryTemplateImages.ts:7
- Draft comment:
Confirm key wpid_356554024867713766 correctly maps to contact forms image. - Reason this comment was not posted:
Confidence changes required:0%
None
Workflow ID: wflow_vb7ig2sRzbeyyVSY
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 5fb163f in 18 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
4drafted comments based on config settings.
1. skyvern-frontend/src/routes/discover/TemporaryTemplateImages.ts:2
- Draft comment:
New asset import is clear and follows naming conventions. - Reason this comment was not posted:
Confidence changes required:0%
None
2. skyvern-frontend/src/routes/discover/TemporaryTemplateImages.ts:7
- Draft comment:
Mapping added for contactForms; ensure key matches intended template. - Reason this comment was not posted:
Confidence changes required:0%
None
3. skyvern-frontend/src/routes/discover/TemporaryTemplateImages.ts:2
- Draft comment:
Ensure the '@/assets/contact-forms.png' asset exists and is correctly resolved. - Reason this comment was not posted:
Confidence changes required:0%
None
4. skyvern-frontend/src/routes/discover/TemporaryTemplateImages.ts:7
- Draft comment:
Mapping for contact forms is added; verify that the key 'wpid_356554024867713766' is correct and unique. - Reason this comment was not posted:
Confidence changes required:0%
None
Workflow ID: wflow_CQBmQvkZnT42Gs0R
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
msalihaltun
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add
contactFormsImagetoTEMPORARY_TEMPLATE_IMAGESinTemporaryTemplateImages.ts.contactFormsImageimport from@/assets/contact-forms.pnginTemporaryTemplateImages.ts.wpid_356554024867713766: contactFormsImagetoTEMPORARY_TEMPLATE_IMAGESinTemporaryTemplateImages.ts.This description was created by
for 5fb163f. It will automatically update as commits are pushed.